-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve scheduled fuzzer workflow #7842
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Dec 2, 2023
assignUser
commented
Dec 2, 2023
assignUser
commented
Dec 2, 2023
assignUser
changed the title
[WIP] Use mold to speed up linking and reduce memory footprint.
[WIP] Improve scheduled fuzzer workflow
Dec 3, 2023
assignUser
force-pushed
the
refactor-fuzzer
branch
from
December 4, 2023 17:54
53b635c
to
471b23d
Compare
assignUser
changed the title
[WIP] Improve scheduled fuzzer workflow
Improve scheduled fuzzer workflow
Dec 4, 2023
kgpai
reviewed
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good.
kgpai
approved these changes
Dec 7, 2023
kgpai
reviewed
Dec 7, 2023
kgpai
reviewed
Dec 7, 2023
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
assignUser
force-pushed
the
refactor-fuzzer
branch
from
December 8, 2023 00:12
de19053
to
595bd01
Compare
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tackles several issues with the scheduled fuzzer workflow:
mold
as a linkerworkflow_dispatch
trigger to enable ad hoc runs of the fuzzer jobspull_request
trigger to enable testing of the workflow in PRs (like this one ^^)Reverts #7811 to use 8-core machines again. Supersedes #7810