Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor greatest and least Presto functions using simple function API #9308

Closed
wants to merge 16 commits into from
Closed

Refactor greatest and least Presto functions using simple function API #9308

wants to merge 16 commits into from

Commits on Mar 29, 2024

  1. Refactor greatest/least functions using simple API

    @Real-Chen-Happy
    Real-Chen-Happy committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    f8998f9 View commit details
    Browse the repository at this point in the history

  2. Add support for Decimal Type and fix compilation issues

    @Real-Chen-Happy
    Real-Chen-Happy committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    4222947 View commit details
    Browse the repository at this point in the history

  3. Fix the comments issues

    @Real-Chen-Happy
    Real-Chen-Happy committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    8bfa725 View commit details
    Browse the repository at this point in the history

  4. Remove the unused include

    @Real-Chen-Happy
    Real-Chen-Happy committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    b285c80 View commit details
    Browse the repository at this point in the history

  5. Refactor the checkNan as generic function

    @Real-Chen-Happy
    Real-Chen-Happy committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    f5187fe View commit details
    Browse the repository at this point in the history

  6. Return null if input size is 0

    @Real-Chen-Happy
    Real-Chen-Happy committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    aff75bb View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Refactoring code based on the code reviews

    @Real-Chen-Happy
    Real-Chen-Happy committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    1b257c5 View commit details
    Browse the repository at this point in the history

  2. Support comparison for NaN for DOUBLE and REAL data types

    @Real-Chen-Happy
    Real-Chen-Happy committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    d030968 View commit details
    Browse the repository at this point in the history

  3. Remove unused includes

    @Real-Chen-Happy
    Real-Chen-Happy committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    2d2d55a View commit details
    Browse the repository at this point in the history

  4. Move extreme function to details scope

    @Real-Chen-Happy
    Real-Chen-Happy committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    74d8652 View commit details
    Browse the repository at this point in the history

  5. Adding comma to the comments

    @Real-Chen-Happy
    Real-Chen-Happy committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    8c8a8ad View commit details
    Browse the repository at this point in the history

  6. Fix the nit issues in the code review

    @Real-Chen-Happy
    Real-Chen-Happy committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    696a4fa View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Refactor the test

    @Real-Chen-Happy
    Real-Chen-Happy committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    02ee69b View commit details
    Browse the repository at this point in the history

  2. Using std::nan for double

    @Real-Chen-Happy
    Real-Chen-Happy committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    3903abb View commit details
    Browse the repository at this point in the history

  3. Fix nit issues in code review

    @Real-Chen-Happy
    Real-Chen-Happy committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    c4f9751 View commit details
    Browse the repository at this point in the history

  4. Refactor register function name

    @Real-Chen-Happy
    Real-Chen-Happy committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    7f76957 View commit details
    Browse the repository at this point in the history