Compile and ship Csmith as part of python package. #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when the csmith dataset is first used, the source code is downloaded, unpacked and compiled on the local machine. This can cause issues for systems without a standard toolchain for building C code, or for other systems with limitations on running arbitrary code, for example, in Google's Colab notebook environments. This patch adds csmith to the set of compiled C code used to build the CompilerGym package. It adds the generated binaries and headers to the pip wheel so that `pip install compiler_gym` will ship with a working Csmith binary. Fixes facebookresearch#345.
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## development #348 +/- ##
===============================================
- Coverage 85.88% 85.83% -0.06%
===============================================
Files 87 87
Lines 4796 4750 -46
===============================================
- Hits 4119 4077 -42
+ Misses 677 673 -4
Continue to review full report at Codecov.
|
ChrisCummins
force-pushed
the
csmith-bin
branch
from
f8d3a9d
to
63acf99
Compare
This was referenced Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when the csmith dataset is first used, the source code is
downloaded, unpacked and compiled on the local machine. This can cause
issues for systems without a standard toolchain for building C code,
or for other systems with limitations on running arbitrary code, for
example, in Google's Colab notebook environments.
This patch adds csmith to the set of compiled C code used to build the
CompilerGym package. It adds the generated binaries and headers to the
pip wheel so that
pip install compiler_gymwill ship with a workingCsmith binary.
Fixes #345.