Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Don't fail CI jobs if code coverage upload fails. #444

Merged

Conversation

ChrisCummins
Copy link
Contributor

No description provided.

@ChrisCummins ChrisCummins added this to the v0.2.1 milestone Sep 29, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2021

Codecov Report

Merging #444 (d85eabf) into development (4ba9a7a) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #444      +/-   ##
===============================================
+ Coverage        87.36%   87.37%   +0.01%     
===============================================
  Files              104      104              
  Lines             5966     5966              
===============================================
+ Hits              5212     5213       +1     
+ Misses             754      753       -1     
Impacted Files Coverage Δ
compiler_gym/views/observation.py 96.87% <0.00%> (-3.13%) ⬇️
compiler_gym/views/observation_space_spec.py 90.42% <0.00%> (-1.07%) ⬇️
compiler_gym/datasets/dataset.py 85.71% <0.00%> (-0.80%) ⬇️
...loop_tool/service/loop_tool_compilation_session.py 90.27% <0.00%> (+0.69%) ⬆️
compiler_gym/service/connection.py 77.58% <0.00%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ba9a7a...d85eabf. Read the comment docs.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 29, 2021
@ChrisCummins ChrisCummins merged commit 5cf6d9b into facebookresearch:development Sep 29, 2021
@ChrisCummins ChrisCummins deleted the ci-fail-on-codecov branch September 29, 2021 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants