Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loop opt service #517

Merged
merged 22 commits into from
Jan 1, 2022
Merged

Loop opt service #517

merged 22 commits into from
Jan 1, 2022

Conversation

mostafaelhoushi
Copy link
Contributor

@mostafaelhoushi mostafaelhoushi commented Dec 14, 2021

A dedicated CompilerGym service for loop optimizations:

  • Add loop unrolling and loop vectorization factors to the action space

Next steps for future PRs:

  • Create env.next_loop() or env.set_loops(i) or env.set_all_loops() APIs to control which loops to optimize
  • Provide observations for the selected loop(s) in addition to module-wide observations

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 14, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2021

Codecov Report

Merging #517 (c07f1eb) into development (c06875e) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #517      +/-   ##
===============================================
- Coverage        87.36%   87.31%   -0.05%     
===============================================
  Files              113      113              
  Lines             6411     6411              
===============================================
- Hits              5601     5598       -3     
- Misses             810      813       +3     
Impacted Files Coverage Δ
...loop_tool/service/loop_tool_compilation_session.py 86.57% <0.00%> (-2.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c06875e...c07f1eb. Read the comment docs.

@mostafaelhoushi mostafaelhoushi changed the title WIP: Loop opt service Loop opt service Dec 27, 2021
@mostafaelhoushi mostafaelhoushi marked this pull request as ready for review December 27, 2021 20:47
Copy link
Contributor

@ChrisCummins ChrisCummins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! I left some small nitpicks inline

examples/example_unrolling_service/example.py Show resolved Hide resolved
examples/loop_optimizations_service/__init__.py Outdated Show resolved Hide resolved
examples/loop_optimizations_service/__init__.py Outdated Show resolved Hide resolved
examples/loop_optimizations_service/README.md Outdated Show resolved Hide resolved
examples/loop_optimizations_service/benchmarks/BUILD Outdated Show resolved Hide resolved
examples/loop_optimizations_service/example.py Outdated Show resolved Hide resolved
@mostafaelhoushi
Copy link
Contributor Author

Thanks for the review. Rebased with master and addressed all comments.

@mostafaelhoushi
Copy link
Contributor Author

I just added a example_without_bazel.py script for loop optimizations

@mostafaelhoushi mostafaelhoushi merged commit 9d7977c into development Jan 1, 2022
@ChrisCummins
Copy link
Contributor

Woop, thanks @mostafaelhoushi!

BTW just a tiny thing - could you submit future PRs from a fork, rather than branching off the main repo? That way it keeps the number of branches down (should be just development, stable, and gh-pages) to keep things clean for when others fork it. Thanks!

Chris

@ChrisCummins ChrisCummins deleted the loop-opt-service branch January 10, 2022 16:19
@mostafaelhoushi
Copy link
Contributor Author

Woop, thanks @mostafaelhoushi!

BTW just a tiny thing - could you submit future PRs from a fork, rather than branching off the main repo? That way it keeps the number of branches down (should be just development, stable, and gh-pages) to keep things clean for when others fork it. Thanks!

Chris

Yes, sure. I should have done that. I will make sure future PRs are from a fork.

This was referenced Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants