Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor out Env interface from CompilerEnv #633

Merged
merged 16 commits into from
Mar 29, 2022
Merged

Refactor out Env interface from CompilerEnv #633

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
e785540
Refactor out Env interface from CompilerEnv
sogartar Mar 5, 2022
ecf42fb
Rename CompilerEnv to ClientServiceCompilerEnv
sogartar Mar 22, 2022
4a79017
Rename Env to CompilerEnv
sogartar Mar 22, 2022
1e6595e
Extend CompilerEnv interface
sogartar Mar 23, 2022
d667d7f
Rename back some occurrences of ClientServiceCompilerEnv to CompilerEnv
sogartar Mar 23, 2022
f760d42
Move ClientServiceCompilerEnv to service
sogartar Mar 24, 2022
621cace
Edit documentation for CompilerEnv and ClientServiceCompilerEnv
sogartar Mar 24, 2022
2acd700
Remove duplicate benchmark property from ClientServiceCompilerEnv
sogartar Mar 24, 2022
2b041d6
Add missing methods to CompilerEnv
sogartar Mar 25, 2022
b7f0ac0
Rename in a few places ClientServiceCompilerEnv to CompilerEnv
sogartar Mar 25, 2022
33a17cc
Add ClientServiceCompilerEnv to documentation
sogartar Mar 25, 2022
4715691
Remove comments of some members in ClientServiceCompilerEnv
sogartar Mar 25, 2022
64f3ef2
Add expected warning in test_wrapped_set_benchmark
sogartar Mar 25, 2022
4230f9f
Use convert_observation in ConcatActionsHistogram
sogartar Mar 26, 2022
165b385
Add reference to PR in a comment about circular dependency
sogartar Mar 28, 2022
3b9518a
Fix implementation of inheritace from ObservationWrapper and RewardWr…
sogartar Mar 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions benchmarks/bench_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import examples.example_compiler_gym_service as dummy
from compiler_gym.envs import CompilerEnv, LlvmEnv, llvm
from compiler_gym.service import CompilerGymServiceConnection
from compiler_gym.service.client_service_compiler_env import ClientServiceCompilerEnv
from tests.pytest_plugins.llvm import OBSERVATION_SPACE_NAMES, REWARD_SPACE_NAMES
from tests.test_main import main

Expand Down Expand Up @@ -56,8 +57,8 @@ def test_make_local(benchmark, env_id):
"args",
[
(llvm.LLVM_SERVICE_BINARY, LlvmEnv),
(dummy.EXAMPLE_CC_SERVICE_BINARY, CompilerEnv),
(dummy.EXAMPLE_PY_SERVICE_BINARY, CompilerEnv),
(dummy.EXAMPLE_CC_SERVICE_BINARY, ClientServiceCompilerEnv),
(dummy.EXAMPLE_PY_SERVICE_BINARY, ClientServiceCompilerEnv),
],
ids=["llvm", "dummy-cc", "dummy-py"],
)
Expand Down
2 changes: 1 addition & 1 deletion compiler_gym/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ py_library(
deps = [
":validation_error",
":validation_result",
"//compiler_gym/envs:compiler_env",
"//compiler_gym/service:client_service_compiler_env",
"//compiler_gym/spaces",
"//compiler_gym/util",
],
Expand Down
2 changes: 1 addition & 1 deletion compiler_gym/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ cg_py_library(
DEPS
::validation_error
::validation_result
compiler_gym::envs::compiler_env
compiler_gym::service::client_service_compiler_env
compiler_gym::spaces::spaces
compiler_gym::util::util
PUBLIC
Expand Down
2 changes: 0 additions & 2 deletions compiler_gym/envs/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ py_library(
"//compiler_gym:compiler_env_state",
"//compiler_gym:validation_result",
"//compiler_gym/datasets",
"//compiler_gym/service",
"//compiler_gym/service/proto",
"//compiler_gym/spaces",
"//compiler_gym/util",
"//compiler_gym/views",
Expand Down
8 changes: 3 additions & 5 deletions compiler_gym/envs/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,11 @@ cg_py_library(
SRCS
"compiler_env.py"
DEPS
compiler_gym::compiler_env_state
compiler_gym::datasets::datasets
compiler_gym::service::service
compiler_gym::service::proto::proto
compiler_gym::spaces::spaces
compiler_gym::util::util
compiler_gym::validation_result
compiler_gym::views::views
compiler_gym::compiler_env_state
compiler_gym::validation_result
compiler_gym::datasets::datasets
PUBLIC
)
Loading