Jotaibench

[canesche]

Adding Benchmark

Benchmark Jotai is a subset of Anghabench which is only composed of programs that have been modified to be executable.

This pull request introduces the benchmark and its dependencies.

[facebook-github-bot]

Hi @canesche!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[codecov-commenter]

Codecov Report

Merging #705 (f82089f) into development (1c40e5b) will decrease coverage by 33.93%.
The diff coverage is 35.82%.

@@               Coverage Diff                @@
##           development     #705       +/-   ##
================================================
- Coverage        89.28%   55.34%   -33.94%     
================================================
  Files              130      131        +1     
  Lines             7912     7979       +67     
================================================
- Hits              7064     4416     -2648     
- Misses             848     3563     +2715     

Impacted Files	Coverage Δ
compiler_gym/envs/llvm/datasets/jotaibench.py	33.84% <33.84%> (ø)
compiler_gym/envs/llvm/datasets/__init__.py	100.00% <100.00%> (ø)
compiler_gym/util/permutation.py	0.00% <0.00%> (-100.00%)	⬇️
compiler_gym/leaderboard/__init__.py	0.00% <0.00%> (-100.00%)	⬇️
compiler_gym/service/runtime/__init__.py	0.00% <0.00%> (-100.00%)	⬇️
compiler_gym/service/runtime/benchmark_cache.py	0.00% <0.00%> (-100.00%)	⬇️
...mpiler_gym/service/runtime/compiler_gym_service.py	0.00% <0.00%> (-100.00%)	⬇️
...ice/runtime/create_and_run_compiler_gym_service.py	0.00% <0.00%> (-100.00%)	⬇️
compiler_gym/envs/gcc/service/gcc_service.py	0.00% <0.00%> (-95.98%)	⬇️
compiler_gym/leaderboard/llvm_instcount.py	0.00% <0.00%> (-92.79%)	⬇️
... and 81 more

[ChrisCummins]

Hi @canesche, many thanks for this! Looking forward to integrate your dataset.

There are some test failures reported by the CI. Please fix them and run make install install-test to check locally that everything is as expected.

There are also some code formatting inconsistencies. You can check these (and fix most of them automatically) through pre-commit. See: https://github.com/facebookresearch/CompilerGym/blob/development/.pre-commit-config.yaml#L2-L17

Cheers,
Chris

[ChrisCummins]

Would you be happy for us to host a mirror of this file? If so, that's great, I can add it in a follow-up PR.

[pronesto]

Hi Chris. I will leave that up to you. If you prefer, that's fine. But we will be updating the benchmarks, so the Jotai collection might change in the future.

[ChrisCummins]

Okay, sounds good, thanks 🙂

[ChrisCummins]

A couple of bits of documentation need to be updated for this new dataset. Please add an entry in the table here:

https://github.com/facebookresearch/CompilerGym/blob/development/docs/source/llvm/index.rst#datasets

And then add an .. autoclass:: entry in the list of datasets here:

https://github.com/facebookresearch/CompilerGym/blob/development/docs/source/llvm/api.rst#datasets

Both are alphabetically sorted.

Cheers,
Chris

[ChrisCummins]

Hi @canesche, getting there, but now the version number needs downgrading 🙂 . If you do a quick find-and-replace for jotaibench-v1 to jotaibench-v0 then I can land this, assuming no problems with the tests

[canesche]

Hi @ChrisCummins, ok I'll replace the jotaibench's version.