[llvm] Fix the number of runtime observations in reward reset. #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## development #761 +/- ##
================================================
- Coverage 89.28% 55.72% -33.56%
================================================
Files 130 130
Lines 7912 7917 +5
================================================
- Hits 7064 4412 -2652
- Misses 848 3505 +2657
|
This adds a `resend_on_reset` flag to the `send_params()` method that enables parameters to be resent immediately after a service is reset. This is required by the LLVM environment to ensure that the runtime observation parameters are sent before the reward space is reset. Fixes facebookresearch#756.
ChrisCummins
changed the title
|
cc @lqwk, patch posted. I'll merge once tests pass. Cheers, |
|
@ChrisCummins thanks for the fix! |
|
Merged via #767. |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
resend_on_resetflag to thesend_params()method thatenables parameters to be resent immediately after a service is
reset. This is required by the LLVM environment to ensure that the
runtime observation parameters are sent before the reward space is
reset.
Fixes #756.