This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenroller
force-pushed
the
unittestmodels
branch
from
September 5, 2018 19:14
37640fc
to
84b0fc6
Compare
stephenroller
force-pushed
the
unittestmodels
branch
from
September 5, 2018 21:47
a1bb227
to
9c49af6
Compare
Merged
Ready for review, fixes #923 for all intents and purposes. |
alexholdenmiller
approved these changes
Sep 12, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, thanks @stephenroller!
@@ -95,6 +101,7 @@ def test_share(self): | |||
shared = agent.share() | |||
self.assertTrue('dict' in shared) | |||
|
|||
@unittest.skipIf(SKIP_TESTS, "Torch not installed.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooh cool
stephenroller
added a commit
that referenced
this pull request
Sep 12, 2018
This reverts commit 70818a8.
Merged
This was referenced Nov 4, 2022
This was referenced Nov 5, 2022
This was referenced Dec 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two simple tasks (repeat the input) which can test both ranking and generative models. The idea is small models should be able to learn these tasks in under a minute on CPU.
Actual tests incoming.