Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Integration test tasks #1122

Merged
merged 10 commits into from
Sep 12, 2018
Merged

Integration test tasks #1122

merged 10 commits into from
Sep 12, 2018

Conversation

stephenroller
Copy link
Contributor

Two simple tasks (repeat the input) which can test both ranking and generative models. The idea is small models should be able to learn these tasks in under a minute on CPU.

Actual tests incoming.

@stephenroller stephenroller self-assigned this Aug 29, 2018
@stephenroller stephenroller changed the title [wip] Unit test tasks Unit test tasks Sep 5, 2018
@stephenroller stephenroller mentioned this pull request Sep 5, 2018
@stephenroller stephenroller changed the base branch from master to lint_tasklist September 5, 2018 21:48
@stephenroller stephenroller changed the title Unit test tasks Integration test tasks Sep 10, 2018
@stephenroller
Copy link
Contributor Author

stephenroller commented Sep 10, 2018

Ready for review, fixes #923 for all intents and purposes.

Copy link
Member

@alexholdenmiller alexholdenmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks @stephenroller!

@@ -95,6 +101,7 @@ def test_share(self):
shared = agent.share()
self.assertTrue('dict' in shared)

@unittest.skipIf(SKIP_TESTS, "Torch not installed.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh cool

@stephenroller stephenroller merged commit 70818a8 into lint_tasklist Sep 12, 2018
@stephenroller stephenroller deleted the unittestmodels branch September 12, 2018 19:50
stephenroller added a commit that referenced this pull request Sep 12, 2018
@stephenroller stephenroller restored the unittestmodels branch September 12, 2018 19:53
@stephenroller stephenroller deleted the unittestmodels branch September 12, 2018 19:57
@stephenroller stephenroller mentioned this pull request Sep 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants