Commits on Jun 29, 2017

1. bug fixes in drqa …

   The default key for the NULL token is `'__NULL__'` (See line 59 in
   parlai/core/dict.py), but `'<NULL>'` is used in line 193 and line 226
   of parlai/agents/drqa/drqa.py. As a result, `'<NULL>'` is treated as an
   unknown word and the index of `'__UNK__'` is actually used for padding,
   which is not expected.
   
   The string 'merge_mode' only appears in line 80 of
   parlai/agents/drqa/rnn\_reader.py, which seems to be a typo. It should
   be 'question\_mode'.

   

   hitvoice committed Jun 29, 2017
   Configuration menu

   • View commit details
   • Copy full SHA for 03d2dc3
   • Browse repository at this point

   Copy the full SHA

   03d2dc3 View commit details

   Browse the repository at this point in the history

2. replace the hard encoding

   

   hitvoice committed Jun 29, 2017
   Configuration menu

   • View commit details
   • Copy full SHA for 3df17f5
   • Browse repository at this point

   Copy the full SHA

   3df17f5 View commit details

   Browse the repository at this point in the history