This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
fix to seq2seq model #453
Merged
fix to seq2seq model #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaseweston
reviewed
Dec 15, 2017
| @@ -421,8 +422,9 @@ def valid(obs): | |||
| y.extendleft(reversed(x)) | |||
|
|
|||
| max_y_len = max(len(y) for y in parsed_y) | |||
| for y in parsed_y: | |||
| y += [self.NULL_IDX] * (max_y_len - len(y)) | |||
| parsed_y = [y if len(y) == max_y_len else | |||
There was a problem hiding this comment.
this is padding things? should be a utility or something?
There was a problem hiding this comment.
you're right--this is padding. could be a utility but I'd like to land this first at least.
jaseweston
approved these changes
Dec 15, 2017
This was referenced Nov 4, 2022
This was referenced Dec 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
history was remembering the zero padding, so need to allocate new object when padding