[SDP][Minor] Removing an assert which does not seem always accurate #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
blefaudeux
commented
Apr 22, 2021
| return is_bn and not isinstance( | ||
| module, tuple(default_auto_wrap_policy.EXCLUDE_WRAP_MODULES) | ||
| ) # type: ignore | ||
| return is_bn and not isinstance(module, tuple(default_auto_wrap_policy.EXCLUDE_WRAP_MODULES)) # type: ignore |
There was a problem hiding this comment.
unrelated, but master linting was broken because of that
blefaudeux
commented
Apr 22, 2021
| @@ -288,6 +288,14 @@ def test_train_eval_change(): | |||
| dist.destroy_process_group() | |||
|
|
|||
|
|
|||
| def test_train_eval_change(): | |||
| world_size = 4 | |||
There was a problem hiding this comment.
making the test case truly distributed, but still not seeing the issue which was reported in a somewhat similar situation. My guess is that there are some changes on the lightning side which make it a little more than just .train()/.eval(), but crashing on users is probably not a good idea in that case. Worst case is a lost step() worth of gradients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes https://fb.workplace.com/groups/pytorchLightning/permalink/1432835657052968/
I'm not super clear on why this happens, but the general thinking is that this was a hard guard on not loosing any gradient, and actually the user may want to do to whatever (like, but may not be all of it: no_sync()fw/bw, then .eval()).
Keep the warning so that it's somewhat visible
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃