Re-enable Query_L2_MMCodeDistance and Query_IP_MMCodeDistance tests for ROCm #3838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D62283662 |
Summary: ROCm does not require CUDA, this change stops installing it. This is also likely to fix #3787 which is coming in a separate change. Differential Revision: D62283602
Summary: This is a prerequisite to fixing issue 3787 and an upgrade to a newer stable version. Differential Revision: D62284555
…or ROCm (#3838) Summary: This fixes 3787 now that we do not install CUDA for ROCm builds. Differential Revision: D62283662
facebook-github-bot
force-pushed
the
export-D62283662
branch
from
7a6a1b6
to
3f46f9f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62283662 |
|
This PR fixes: issue #3787 |
|
This pull request has been merged in 3f41161. |
4 tasks
aalekhpatel07
pushed a commit
to aalekhpatel07/faiss
that referenced
this pull request
Oct 17, 2024
…or ROCm (facebookresearch#3838) Summary: Pull Request resolved: facebookresearch#3838 This fixes 3787 now that we do not install CUDA for ROCm builds. Reviewed By: mengdilin Differential Revision: D62283662 fbshipit-source-id: e5c736296b1c6d7b9a6b9f60161ffe3b5cb1c699
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This fixes 3787 now that we do not install CUDA for ROCm builds.
Differential Revision: D62283662