Add packed bit field support to Row Structure #493
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D43366173 |
robotal
pushed a commit
to robotal/fbpcf
that referenced
this pull request
Feb 16, 2023
Summary: Pull Request resolved: facebookresearch#493 # Background: Currently in order to successfully use UDP, you must write some carefully crafted code that will take all the rows of metadata for one side and package it into a collection of bytes. Afterwards the caller will get a `SecString` object back which is a bit representation of all the bytes they passed in, minus the filtered out rows. The user must then extract the corresponding bits for each column into separate MPC Types. This is a cumbersome process which is error prone, as you must make sure to carefully match up the two steps and any changes can cause a bug. # This Diff Adds support to RowDefinition for packed bits. Right now you directly pass in the column names that are to be packed, and the interface will combine each column. The output will contain columns in a vector form. I will refactor that in a future diff to make a bit easier to use. Differential Revision: D43366173 fbshipit-source-id: d07ca02e52ad597cbd826d09ceb4b13491d12eda
robotal
force-pushed
the
export-D43366173
branch
from
4dcc488 to
966685a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D43366173 |
Differential Revision: D43341286 fbshipit-source-id: b6a0e068caa5ad5da40729eceee3dad71858fe84
Differential Revision: D43366172 fbshipit-source-id: 6c9985bee4518333521160ae3071db2d65c228ee
Differential Revision: https://www.internalfb.com/diff/D43208067?entry_point=27 fbshipit-source-id: 20440bd731d55f11e5465367a7b77a213deffeb6
Summary: Pull Request resolved: facebookresearch#493 # Background: Currently in order to successfully use UDP, you must write some carefully crafted code that will take all the rows of metadata for one side and package it into a collection of bytes. Afterwards the caller will get a `SecString` object back which is a bit representation of all the bytes they passed in, minus the filtered out rows. The user must then extract the corresponding bits for each column into separate MPC Types. This is a cumbersome process which is error prone, as you must make sure to carefully match up the two steps and any changes can cause a bug. # This Diff Adds support to RowDefinition for packed bits. Right now you directly pass in the column names that are to be packed, and the interface will combine each column. The output will contain columns in a vector form. I will refactor that in a future diff to make a bit easier to use. Reviewed By: haochenuw Differential Revision: D43366173 fbshipit-source-id: 4062cfedf7fdecbeea7a10325980d89b623d335a
robotal
force-pushed
the
export-D43366173
branch
from
966685a to
872cb4f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D43366173 |
|
This pull request has been merged in 2f51aa1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Background:
Currently in order to successfully use UDP, you must write some carefully crafted code that will take all the rows of metadata for one side and package it into a collection of bytes. Afterwards the caller will get a
SecStringobject back which is a bit representation of all the bytes they passed in, minus the filtered out rows. The user must then extract the corresponding bits for each column into separate MPC Types. This is a cumbersome process which is error prone, as you must make sure to carefully match up the two steps and any changes can cause a bug.This Diff
Adds support to RowDefinition for packed bits. Right now you directly pass in the column names that are to be packed, and the interface will combine each column. The output will contain columns in a vector form. I will refactor that in a future diff to make a bit easier to use.
Differential Revision: D43366173