Switch to a multiplatform mmap implementation. #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
10 tasks
I believe you can find them here: |
|
Ah! :) Will check those out tomorrow, then. |
erikwijmans
reviewed
Jul 16, 2019
It has a RAII interface, so no need for explicit unmapping there. Also made the code more const.
It ensures that CORRADE_TARGET_WINDOWS is always defined on Windows. Additionally, I switched to CORRADE_TARGET_UNIX from __linux__ (after excluding CORRADE_TARGET_APPLE) because there's BSD too.
mosra
force-pushed
the
mmap-multiplatform
branch
from
3a6916d
to
7fc47d2
Compare
|
Ok, it took ages to download, but everything seems to work the same way as before! :) |
|
Great, thanks! |
erikwijmans
approved these changes
Jul 18, 2019
9 tasks
eundersander
pushed a commit
to eundersander/habitat-sim
that referenced
this pull request
Aug 6, 2020
…rch#106) The habitat-api-demo.ipynb notebook illustrates how to specify config parameters, print semantic annotations of a scene. It also visualises the RGB, semantic and depth observations obtained by executing a random sequence of actions.
Ram81
pushed a commit
to Ram81/habitat-web-sim
that referenced
this pull request
Dec 10, 2020
* assets: use a multiplatform Corrade::Utility::Directory::mapRead(). It has a RAII interface, so no need for explicit unmapping there. Also made the code more const. * gfx: use Corrade's platform defines for reliable documented behavior. It ensures that CORRADE_TARGET_WINDOWS is always defined on Windows. Additionally, I switched to CORRADE_TARGET_UNIX from __linux__ (after excluding CORRADE_TARGET_APPLE) because there's BSD too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Should help with #84 -- we don't need to reinvent things that are already implemented and tested :) Also made the code a bit more
const-correct and simplified some pointer chasings.How Has This Been Tested
It builds for me on Linux.
⚠️ Even though the change is pretty straightforward, there's not much to screw up and the underlying API has been extensively tested in other contexts, unfortunately I'm afraid I don't have any PTex mesh data to give this a real test, sorry.Types of changes