Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Package name is too long #3

Open
Jiayuan-Gu opened this issue Oct 25, 2018 · 5 comments
Open

Package name is too long #3

Jiayuan-Gu opened this issue Oct 25, 2018 · 5 comments

Comments

@Jiayuan-Gu
Copy link

Jiayuan-Gu commented Oct 25, 2018

Thanks for a good implementation for research community. However, I suggest you use a shorter module's name to replace 'maskrcnn_benchmark', say, 'det' or 'detectron' before more people start to use it. It seems you originally use 'torch_detectron' (inferred from .gitignore).

Another suggestion is to include .idea(Pycharm setting files) in .gitignore.

@fmassa
Copy link
Contributor

fmassa commented Oct 25, 2018

Thanks for your feedback.

We will definitely add a .idea file in .gitignore, would you be willing to send a PR?

About renaming the package, that's a good question. We will discuss it and come back to you.

@Jiayuan-Gu
Copy link
Author

Thanks for replying. I would send a PR for updating .gitignore file. Hope that you will find a better name.

@ASH1998
Copy link

ASH1998 commented Oct 25, 2018

Awesome @Jiayuan-Gu I was wondering the same thing... :octocat:

@paleckar
Copy link

Don't IDE-specific files generally belong to the global .gitignore?

@fmassa
Copy link
Contributor

fmassa commented Oct 26, 2018

@paleckar I don't know, I don't use IDEs :-)
But we've added it in the .gitignore from maskrcnn-benchmark, so it should be fine even if unnecessary?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants