This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Raise error if no GT or proposals available during training #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
soumith
reviewed
Oct 26, 2018
| # empty targets or proposals not supported during training | ||
| if match_quality_matrix.shape[0] == 0: | ||
| raise ValueError( | ||
| "No ground-truth boxes available for one of the images " |
There was a problem hiding this comment.
make it tell the user which image / filename if possible. otherwise it becomes a bit of a nightmare to track back
There was a problem hiding this comment.
I agree as well, but for the image names to be displayed in the error message means that the assert would need to be applied in the user code as well, when they create a new Dataset class
Open
|
Propagating which image yielded the empty target can be a bit tricky as there might have been random crops etc. Maybe I'll add another assert like this in the Dataset itself, but in the meantime I'll be merging this as is. |
Open
nprasad2021
pushed a commit
to nprasad2021/maskrcnn-benchmark
that referenced
this pull request
Jan 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help catch problems similar to the one in #31