-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugging new parametrization inside instrumentation and optimization #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrapin
requested review from
teytaud,
baptisteroziere,
LaurentMnr95 and
danthe3rd
December 30, 2019 10:47
This was referenced Jan 2, 2020
jrapin
commented
Jan 6, 2020
For the record: |
This was referenced Jan 13, 2020
This was referenced Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
Do not delete this pull request or issue due to inactivity.
Difficulty: High
Priority: Critical
Status: Review needed
Type: Breaking changes
Breaking changes to the API, to be notified in changelogs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and Context / Related issue
How Has This Been Tested (if it applies)
FYI: this is expected to land after January 8th
This plugs parametrization as created in #323
To do so, the new
Instrumentation
is extended with oldVariable
methods, and the oldVariable
inherits fromInstrumentation
and overrides the new methods.This is not expected to change anything for you, but some printed information may change, and deprecation warnings will appear for some methods (Eg.:
set_cheap_constraint_checker
->register_cheap_constraint
with a slightly different API). Some probably unused functions will disappear (get_description
) making the changes breaking anyway. At this point you will be able to use newParameter
classes, but their initialization may be inaccurate so it will not be advised in some cases (you would get a user warning). Also, because of the compatibility, we expect optimizers to be about 25% slower in this version. The optimizer will still only take anInstrumentation
(new version) as input for its initialization.Checklist