Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Prepare new parametrized function #403

Closed
wants to merge 21 commits into from
Closed

[WIP] Prepare new parametrized function #403

wants to merge 21 commits into from

Conversation

jrapin
Copy link
Contributor

@jrapin jrapin commented Dec 21, 2019

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

Simpler API to specify parametrization in benchmarks

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 21, 2019
@jrapin jrapin mentioned this pull request Dec 30, 2019
Merged
7 tasks
@jrapin jrapin changed the base branch from variable_as_instrumentation to master December 30, 2019 10:51
@jrapin jrapin changed the base branch from master to instrumentation_v3 December 30, 2019 10:53
@jrapin
Copy link
Contributor Author

jrapin commented Dec 30, 2019

moved to #421

@jrapin jrapin closed this Dec 30, 2019
@jrapin jrapin deleted the parametrized_function branch December 30, 2019 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrapin @facebook-github-bot