Clean up some code in games and powersystem #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
jrapin
commented
Dec 30, 2019
| history2 = 2 * history2 + 2 # illegal move. | ||
|
|
||
| return 1 if p.score() > 0 else 2 | ||
| # TODO remove if not planned to be used |
There was a problem hiding this comment.
Is the following planned to be used (phantomgo)? there are many undefined variables so I commented it, but if possible we should remove it
| p1 = x[:(self.dimension // 2)] | ||
| p2 = self.instrumentation.random_state.normal(size=self.dimension // 2) | ||
| p2 = np.random.normal(size=self.dimension // 2) |
There was a problem hiding this comment.
Using instrumentation indeed does not work, I'll try to update this when I simplify the InstrumentedFunction mess to something way simpler
jrapin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and Context / Related issue
How Has This Been Tested (if it applies)
Checklist