Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NGO: in low dim and hard thresholding, use FastGA variant #426

Merged
merged 1 commit into from
Jan 2, 2020
Merged

NGO: in low dim and hard thresholding, use FastGA variant #426

merged 1 commit into from
Jan 2, 2020

Conversation

teytaud
Copy link
Contributor

@teytaud teytaud commented Jan 2, 2020

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
  • All tests passed, and additional code has been covered with new tests.

@teytaud teytaud requested a review from jrapin January 2, 2020 06:12
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 2, 2020
@teytaud teytaud merged commit 5bc5d70 into master Jan 2, 2020
@teytaud teytaud deleted the ngo_fix_noise branch January 2, 2020 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrapin jrapin Awaiting requested review from jrapin

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teytaud @facebook-github-bot