Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Parameter in OnePlusOne #599

Merged
merged 5 commits into from
Apr 2, 2020
Merged

Use Parameter in OnePlusOne #599

merged 5 commits into from
Apr 2, 2020

Conversation

jrapin
Copy link
Contributor

@jrapin jrapin commented Apr 1, 2020

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

This will allow to track parenthood in 1+1

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 1, 2020
@jrapin
Copy link
Contributor Author

jrapin commented Apr 1, 2020

This enables using HiPlot to analyze the algorithm:
Screen Shot 2020-04-01 at 4 48 54 PM

@jrapin jrapin merged commit 40fb1cb into master Apr 2, 2020
@jrapin jrapin deleted the param_1p1 branch April 2, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrapin @facebook-github-bot