Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend a candidate when possible #668

Merged
merged 5 commits into from
May 11, 2020
Merged

Recommend a candidate when possible #668

merged 5 commits into from
May 11, 2020

Conversation

jrapin
Copy link
Contributor

@jrapin jrapin commented May 11, 2020

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

For non-deterministic parametrization, this means we won't resample, and we will actually recommend the best past evaluated candidate

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CLA).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 11, 2020
@teytaud
Copy link
Contributor

teytaud commented May 11, 2020

LGTM for the principle of returning a sampled candidate.
admittedly i just checked that the modification was the one I expected to see and did not try to understand much, sorry for low quality review.

@jrapin jrapin merged commit 03313cb into master May 11, 2020
@jrapin jrapin deleted the recommend_candidate branch May 11, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants