Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[factory] First and last layers are not properly tagged -> superfluous layernorms #347

Closed
blefaudeux opened this issue Jul 3, 2022 · 0 comments · Fixed by #348
Closed

[factory] First and last layers are not properly tagged -> superfluous layernorms #347

blefaudeux opened this issue Jul 3, 2022 · 0 comments · Fixed by #348

Comments

@blefaudeux
Copy link
Contributor

🐛 Bug

Related to tests with #330 when generating more complex models from configs, in some cases the layers get mislabelled (several "last layer") meaning that we get a lot of extra layernorms
This was referenced Jul 3, 2022
Merged
Merged
bertmaher pushed a commit to bertmaher/xformers that referenced this issue Dec 20, 2024
@danthe3rd
Merge pull request facebookresearch#347 from fairinternal/ci_always
994d9f4 
Always run all linters in CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] Layer positions labelling & layernorm blefaudeux/xformers
1 participant
@blefaudeux