Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix] dropout test tolerance #170

Merged
merged 1 commit into from
Jan 3, 2022
Merged

[hotfix] dropout test tolerance #170

merged 1 commit into from
Jan 3, 2022

Conversation

blefaudeux
Copy link
Contributor

@blefaudeux blefaudeux commented Jan 3, 2022 •
edited
Loading

What does this PR do?

Fixes flaky dropout prob test, pull more samples

Before submitting

  • Did you have fun?
    • Make sure you had fun coding 🙃
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you update the changelog? (if needed)
    • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 3, 2022
@blefaudeux
Copy link
Contributor Author

cc @fmassa @dianaml0 @jieru-hu

@blefaudeux blefaudeux merged commit 154b819 into main Jan 3, 2022
@blefaudeux blefaudeux deleted the hotfix_dropout_test branch January 3, 2022 21:24
xwhan pushed a commit to xwhan/xformers that referenced this pull request Feb 8, 2022
@blefaudeux
[hotfix] typo in the LRA avg code, update README ( facebookresearch#170)
aa86c9c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blefaudeux @facebook-github-bot