Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix caching the env in between jobs #280

Merged
merged 1 commit into from
Apr 21, 2022
Merged

[CI] Fix caching the env in between jobs #280

merged 1 commit into from
Apr 21, 2022

Conversation

blefaudeux
Copy link
Contributor

What does this PR do?

Minor, properly cache the env in between jobs, speeding up CI a little.
I compared that with not using a cache at all, using a cache is actually faster:

(timings give or take a couple of minutes, but a proper cache is clearly better)

Before submitting

  • Did you have fun?
    • Make sure you had fun coding 🙃
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you update the changelog? (if needed)
    • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 21, 2022
@blefaudeux
Copy link
Contributor Author

insta land @dianaml0 @fmassa, probably not worth too much of your time :)

@blefaudeux blefaudeux merged commit ad94fd1 into main Apr 21, 2022
@blefaudeux blefaudeux deleted the ci_cache_fix branch April 21, 2022 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants