Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conda packages to know their python dep #470

Merged
merged 2 commits into from
Oct 9, 2022

Conversation

bottler
Copy link
Contributor

@bottler bottler commented Oct 8, 2022

bottler added a commit that referenced this pull request Oct 8, 2022
ghstack-source-id: e32749dedb8492e9d37d589f5fe1fe860a3059e0
Pull Request resolved: #470
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 8, 2022
bottler added a commit that referenced this pull request Oct 9, 2022
ghstack-source-id: 5224b0f3466d1ce48043bd2f948e9d3800850ff5
Pull Request resolved: #470
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2022

Codecov Report

Base: 90.52% // Head: 90.52% // No change to project coverage 👍

Coverage data is based on head (f974692) compared to base (fdbf3eb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@                Coverage Diff                 @@
##           gh/bottler/1/base     #470   +/-   ##
==================================================
  Coverage              90.52%   90.52%           
==================================================
  Files                     76       76           
  Lines                   4548     4548           
==================================================
  Hits                    4117     4117           
  Misses                   431      431           
Flag Coverage Δ
Python 90.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bottler bottler merged commit f953c59 into gh/bottler/1/base Oct 9, 2022
danthe3rd added a commit that referenced this pull request Oct 10, 2022
Original change from @bottler 
#470

I would have put the python version constraint as we do for pytorch, but I'm not an expert in those things so I trust hum
@facebook-github-bot facebook-github-bot deleted the gh/bottler/1/head branch November 9, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants