Build windows pip wheels #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov ReportBase: 89.81% // Head: 89.81% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #534 +/- ##
=======================================
Coverage 89.81% 89.81%
=======================================
Files 80 80
Lines 4848 4848
=======================================
Hits 4354 4354
Misses 494 494
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
danthe3rd
reviewed
Nov 20, 2022
danthe3rd
approved these changes
Nov 24, 2022
|
@danthe3rd yes, although it would be great if any windows user could test the built wheels, you can merge it and we can deal with the problems later. |
|
"test in prod" - let's do that :) |
|
Hi @AbdBarho & @danthe3rd , can we test this now? How do i test on windows? |
Merged
bertmaher
pushed a commit
to bertmaher/xformers
that referenced
this pull request
Dec 20, 2024
The script is currently broken in the following situation: * A merge conflict when importing a fairinternal comit (eg because it modifies a fairinternal file and can't be applied) * AND is also removing a file that exists in OSS (without merge conflict) In that case, we try to resolve to the fairinternal version. This leads to removing the OSS file, but it's already removed in the tree because there was no conflict, and hence `git rm FILE` fails. *I also updated the test to reflect this scenario* Co-authored-by: danthe3rd <danthe3rd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As a continuation of #523, adds windows pip wheels.
Before submitting
CUTCLASSnot found #473pip#532PR review
Anyone in the community is free to review the PR once the tests have passed.
Warning
I have no windows machine to test the built wheels, would be great if someone could test it.
You can see the workflow and download the artefacts here:
https://github.com/AbdBarho/xformers-wheels/actions/runs/3518281917
Additional info
Github runners go brrrrrrrrrrrrrrrrrr
The next thing on my todo list would be to optimize the build setup, maybe through docker images or simiar.