Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce binary size - no debug info for binaries #549

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

danthe3rd
Copy link
Contributor

@danthe3rd danthe3rd commented Nov 29, 2022

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 29, 2022
danthe3rd pushed a commit that referenced this pull request Nov 29, 2022
ghstack-source-id: 4759ee88b471d7e10e40c72d9b9d4a441c82aeaf
Pull Request resolved: #549
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2022

Codecov Report

Base: 89.79% // Head: 89.79% // No change to project coverage 👍

Coverage data is based on head (00887a7) compared to base (7538362).
Patch has no changes to coverable lines.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           gh/danthe3rd/58/base     #549   +/-   ##
=====================================================
  Coverage                 89.79%   89.79%           
=====================================================
  Files                        80       80           
  Lines                      4839     4839           
=====================================================
  Hits                       4345     4345           
  Misses                      494      494           
Flag Coverage Δ
Python 89.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@danthe3rd danthe3rd merged commit 1872d2e into gh/danthe3rd/58/base Nov 29, 2022
danthe3rd pushed a commit that referenced this pull request Nov 29, 2022
ghstack-source-id: 05c54697b5e42de004eb5dcfb2c7adc5f10d1c6a
Pull Request resolved: #549
@danthe3rd danthe3rd deleted the gh/danthe3rd/58/head branch November 29, 2022 17:34
bertmaher pushed a commit to bertmaher/xformers that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants