-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI after torchmetrics update #567
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now takes an argument: https://torchmetrics.readthedocs.io/en/stable/classification/accuracy.html [ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Dec 8, 2022
This was referenced Dec 8, 2022
Merged
fmassa
approved these changes
Dec 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
It now takes an argument: https://torchmetrics.readthedocs.io/en/stable/classification/accuracy.html Change in pytorch lightning: Lightning-AI/torchmetrics@20eab43 Somehow this is failing with a SEGFAULT on my A100 (in a triton kernel): ``` #0 0x00007fffc0f62e10 in ?? () from /lib/x86_64-linux-gnu/libcuda.so #1 0x00007fffc0f9303c in ?? () from /lib/x86_64-linux-gnu/libcuda.so #2 0x00007fffc0f2ea13 in ?? () from /lib/x86_64-linux-gnu/libcuda.so #3 0x00007fffc0f94603 in ?? () from /lib/x86_64-linux-gnu/libcuda.so #4 0x00007fffc119e4a0 in ?? () from /lib/x86_64-linux-gnu/libcuda.so #5 0x00007fffc0f3728f in ?? () from /lib/x86_64-linux-gnu/libcuda.so #6 0x00007fffc0f3999f in ?? () from /lib/x86_64-linux-gnu/libcuda.so #7 0x00007fffc0fdb1c2 in ?? () from /lib/x86_64-linux-gnu/libcuda.so #8 0x00007fff502234c0 in _launch () from /data/home/XXXXX/.triton/cache/704a3e6949e60326bc68d18a620bee50/layer_norm_fw.so #9 0x00007fff3c0eea25 in launch () from /data/home/XXXXX/.triton/cache/2cebb5590a024a2e06fe9de08c6b7079/k_dropout_bw.so #10 0x0000555555698422 in cfunction_call (func=0x7fff3c6e5760, args=<optimized out>, kwargs=<optimized out>) at /usr/local/src/conda/python-3.10.6/Objects/methodobject.c:552 ``` [ghstack-poisoned]
It now takes an argument: https://torchmetrics.readthedocs.io/en/stable/classification/accuracy.html Change in pytorch lightning: Lightning-AI/torchmetrics@20eab43 Somehow this is failing with a SEGFAULT on my A100 (in a triton kernel): ``` #0 0x00007fffc0f62e10 in ?? () from /lib/x86_64-linux-gnu/libcuda.so #1 0x00007fffc0f9303c in ?? () from /lib/x86_64-linux-gnu/libcuda.so #2 0x00007fffc0f2ea13 in ?? () from /lib/x86_64-linux-gnu/libcuda.so #3 0x00007fffc0f94603 in ?? () from /lib/x86_64-linux-gnu/libcuda.so #4 0x00007fffc119e4a0 in ?? () from /lib/x86_64-linux-gnu/libcuda.so #5 0x00007fffc0f3728f in ?? () from /lib/x86_64-linux-gnu/libcuda.so #6 0x00007fffc0f3999f in ?? () from /lib/x86_64-linux-gnu/libcuda.so #7 0x00007fffc0fdb1c2 in ?? () from /lib/x86_64-linux-gnu/libcuda.so #8 0x00007fff502234c0 in _launch () from /data/home/XXXXX/.triton/cache/704a3e6949e60326bc68d18a620bee50/layer_norm_fw.so #9 0x00007fff3c0eea25 in launch () from /data/home/XXXXX/.triton/cache/2cebb5590a024a2e06fe9de08c6b7079/k_dropout_bw.so #10 0x0000555555698422 in cfunction_call (func=0x7fff3c6e5760, args=<optimized out>, kwargs=<optimized out>) at /usr/local/src/conda/python-3.10.6/Objects/methodobject.c:552 ``` [ghstack-poisoned]
It now takes an argument: https://torchmetrics.readthedocs.io/en/stable/classification/accuracy.html Change in pytorch lightning: Lightning-AI/torchmetrics@20eab43 Somehow this is failing with a SEGFAULT on my A100 (in a triton kernel): ``` #0 0x00007fffc0f62e10 in ?? () from /lib/x86_64-linux-gnu/libcuda.so #1 0x00007fffc0f9303c in ?? () from /lib/x86_64-linux-gnu/libcuda.so #2 0x00007fffc0f2ea13 in ?? () from /lib/x86_64-linux-gnu/libcuda.so #3 0x00007fffc0f94603 in ?? () from /lib/x86_64-linux-gnu/libcuda.so #4 0x00007fffc119e4a0 in ?? () from /lib/x86_64-linux-gnu/libcuda.so #5 0x00007fffc0f3728f in ?? () from /lib/x86_64-linux-gnu/libcuda.so #6 0x00007fffc0f3999f in ?? () from /lib/x86_64-linux-gnu/libcuda.so #7 0x00007fffc0fdb1c2 in ?? () from /lib/x86_64-linux-gnu/libcuda.so #8 0x00007fff502234c0 in _launch () from /data/home/XXXXX/.triton/cache/704a3e6949e60326bc68d18a620bee50/layer_norm_fw.so #9 0x00007fff3c0eea25 in launch () from /data/home/XXXXX/.triton/cache/2cebb5590a024a2e06fe9de08c6b7079/k_dropout_bw.so #10 0x0000555555698422 in cfunction_call (func=0x7fff3c6e5760, args=<optimized out>, kwargs=<optimized out>) at /usr/local/src/conda/python-3.10.6/Objects/methodobject.c:552 ``` [ghstack-poisoned]
This was referenced Dec 9, 2022
danthe3rd
pushed a commit
that referenced
this pull request
Dec 9, 2022
It now takes an argument: https://torchmetrics.readthedocs.io/en/stable/classification/accuracy.html ghstack-source-id: 124e71e10d9e2f513512cdc08e158a0e1f485239 Pull Request resolved: #567
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
It now takes an argument: https://torchmetrics.readthedocs.io/en/stable/classification/accuracy.html
Change in pytorch lightning:
Lightning-AI/torchmetrics@20eab43
Somehow this is failing with a SEGFAULT on my A100 (in a triton kernel):