Rework wrapper parameters to be more flexible (support regex timeout) #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the wrapper function inputs to accept *args and **kwargs instead of explicitly specifying parameters. This allows the API of the underlying library to change without affecting our wrapper. Fixes #112
facelessuser
force-pushed
the
flexible-params
branch
from
52a9a32
to
1d111f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the wrapper function inputs to accept *args and **kwargs
instead of explicitly specifying parameters. This allows the API of the
underlying library to change without affecting our wrapper.
Fixes #112