Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(prettier): optionally respect local prettier rules #6

Merged
merged 10 commits into from
Sep 19, 2022
Merged

feature(prettier): optionally respect local prettier rules #6

merged 10 commits into from
Sep 19, 2022

Conversation

dnnsjrng
Copy link
Member

@dnnsjrng dnnsjrng commented Sep 18, 2022 •
edited
Loading

⚠️ Watchout: This branch is based on https://github.com/factorial-io/drupal-breakpoints-css/tree/feature/apply-prettier-config

Solves #5

  • Add userConfig option to specify prettier config path
  • resolveConfig and merge config to prettier.format
  • upgrade class methods to async methods (honestly this doesn't make any difference but it feels better :D)
  • add missing jsdoc comments
  • rename readYamlFile -> readAndParseYamlConfiguration for better readability

@dnnsjrng dnnsjrng self-assigned this Sep 18, 2022
@dnnsjrng dnnsjrng requested a review from mvsde September 18, 2022 20:06
@dnnsjrng dnnsjrng added the enhancement New feature or request label Sep 18, 2022
mvsde
mvsde requested changes Sep 19, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
lib/types.d.ts Outdated Show resolved Hide resolved
lib/types.d.ts Outdated Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
lib/index.js Show resolved Hide resolved
Base automatically changed from refactor/improve-configuration-and-add-optional-settings to main September 19, 2022 12:28
@dnnsjrng dnnsjrng requested a review from mvsde September 19, 2022 12:47
mvsde
mvsde approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@mvsde mvsde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@dnnsjrng dnnsjrng merged commit e4d3c77 into main Sep 19, 2022
@dnnsjrng dnnsjrng deleted the feature/apply-prettier-config branch September 19, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvsde mvsde mvsde approved these changes

Assignees

@dnnsjrng dnnsjrng

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnnsjrng @mvsde