Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a field_name to support existing entities #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MuschPusch
Copy link
Member

Adds an option to provide a field_name to:

a.) Create fields without the field_ prefix
b.) hijack existing entities with fields which don't follow the current naming convention

Let me know what you think and I can add tests + documentation

@MuschPusch MuschPusch requested a review from d34dman November 30, 2020 12:35
@MuschPusch MuschPusch self-assigned this Nov 30, 2020
Copy link
Member

@d34dman d34dman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice feature :) I would like to get this in! So lets see them tests :)

@d34dman
Copy link
Member

d34dman commented Nov 30, 2020

This can be used to enforce "re-using" of fields too. Not sure if it would increase some bugs though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants