Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix variable number of reviews returned #676 #677

Merged
merged 5 commits into from
Apr 9, 2024
Merged

Fix variable number of reviews returned #676 #677

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c1cf82b
implement cookieJar support
Apr 7, 2024
ee29fb0
minor codestyling
Apr 7, 2024
fa21f94
more codestyling to pass lint
Apr 7, 2024
4e110ef
Update lib/utils/request.js
facundoolano Apr 7, 2024
4461113
add test for equal results (amend PR #677)
Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/utils/request.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
import requestLib from 'got';
import throttled from './throttle.js';
import { CookieJar } from 'tough-cookie';
import createDebug from 'debug';

const cookieJar = new CookieJar();
const debug = createDebug('google-play-scraper');

function doRequest (opts, limit) {
let req;

opts.cookieJar = cookieJar;
facundoolano marked this conversation as resolved.
Show resolved Hide resolved

if (limit) {
req = throttled(
requestLib, {
Expand Down
93 changes: 89 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@
"debug": "^3.1.0",
"got": "^11.8.6",
"memoizee": "^0.4.14",
"ramda": "^0.29.0"
"ramda": "^0.29.0",
"tough-cookie": "^4.1.3"
},
"devDependencies": {
"chai": "^4.3.7",
Expand Down
Loading