Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test cases addition, review within team members #2

Closed
wants to merge 8 commits into from
Closed

test cases addition, review within team members #2

wants to merge 8 commits into from

Conversation

fahadshamiinsta
Copy link
Owner

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

yallen-ic
yallen-ic reviewed Dec 1, 2023
View reviewed changes
.../repository-gcs/src/main/java/org/opensearch/repositories/gcs/GoogleCloudStorageService.java Outdated
public GoogleCloudStorageService() {
this.googleApplicationDefaultCredentials = new GoogleApplicationDefaultCredentials();
}
public GoogleCloudStorageService(GoogleApplicationDefaultCredentials googleApplicationDefaultCredentials) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a stupid question as i am not familar with how it works, but if it is default cred (which I assume won't change for that storage), what is the point of this method that takes in GADC object?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this constructor has been created to cater the test cases, the GoogleApplicationDefaultCredentials is created so that we can mock the calling of static methods

mch2 and others added 3 commits November 30, 2023 19:23
@mch2
Fix bug where replication lag grows post primary relocation (opensear…
6fa3a0d 
…ch-project#11238)

* Fix bug where replication lag grows post primary relocation

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* Fix broken UT

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* add unit test for cluster state update

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* PR feedback

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* add changelog entry

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

---------

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
@vikasvb90
Optimizations in s3 async upload flow (opensearch-project#11327)
77a4daf 
Signed-off-by: vikasvb90 <vikasvb@amazon.com>
@ankitkala
Fix for flaky test IndexServiceTests.testAsyncTranslogTrimTaskOnClose…
69cc2a1 
…dIndex (opensearch-project#11337)

Signed-off-by: Ankit Kala <ankikala@amazon.com>
dependabot bot and others added 5 commits December 4, 2023 09:34
@dependabot
Bump actions/setup-java from 3 to 4 (opensearch-project#11447)
0f835e0 
* Bump actions/setup-java from 3 to 4

Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3 to 4.
- [Release notes](https://github.com/actions/setup-java/releases)
- [Commits](actions/setup-java@v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-java
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update changelog

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
@dependabot
Bump commons-net:commons-net from 3.9.0 to 3.10.0 in /test/fixtures/h…
aeac27b 
…dfs-fixture (opensearch-project#11450)

* Bump commons-net:commons-net in /test/fixtures/hdfs-fixture

Bumps commons-net:commons-net from 3.9.0 to 3.10.0.

---
updated-dependencies:
- dependency-name: commons-net:commons-net
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update changelog

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
@dependabot
Bump commons-io:commons-io from 2.13.0 to 2.15.1 (opensearch-project#…
3f5432e 
…11446)

* Bump commons-io:commons-io from 2.13.0 to 2.15.1

Bumps commons-io:commons-io from 2.13.0 to 2.15.1.

---
updated-dependencies:
- dependency-name: commons-io:commons-io
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update changelog

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
@dependabot
Bump org.apache.maven:maven-model from 3.9.4 to 3.9.6 (opensearch-pro…
35c3532 
…ject#11445)

* Bump org.apache.maven:maven-model from 3.9.4 to 3.9.6

Bumps [org.apache.maven:maven-model](https://github.com/apache/maven) from 3.9.4 to 3.9.6.
- [Release notes](https://github.com/apache/maven/releases)
- [Commits](apache/maven@maven-3.9.4...maven-3.9.6)

---
updated-dependencies:
- dependency-name: org.apache.maven:maven-model
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update changelog

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
@dependabot
Bump org.apache.xmlbeans:xmlbeans from 5.1.1 to 5.2.0 in /plugins/ing…
50babcf 
…est-attachment (opensearch-project#11448)

* Bump org.apache.xmlbeans:xmlbeans in /plugins/ingest-attachment

Bumps org.apache.xmlbeans:xmlbeans from 5.1.1 to 5.2.0.

---
updated-dependencies:
- dependency-name: org.apache.xmlbeans:xmlbeans
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Updating SHAs

Signed-off-by: dependabot[bot] <support@github.com>

* Update changelog

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
@fahadshamiinsta fahadshamiinsta force-pushed the main-repository-gcs-ADC-Support branch 2 times, most recently from b679a72 to 50babcf Compare December 4, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yallen-ic yallen-ic yallen-ic left review comments

@arjunrajnetapp arjunrajnetapp arjunrajnetapp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fahadshamiinsta @yallen-ic @arjunrajnetapp @mch2 @vikasvb90 @ankitkala