Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix261 -- fixes inverted x-axis problem #262

Merged
merged 1 commit into from
Sep 22, 2020
Merged

fix261 -- fixes inverted x-axis problem #262

merged 1 commit into from
Sep 22, 2020

Conversation

RalphSteinhagen
Copy link
Member

fixes wrong label overlap detection that prevented inverted x-axes (see #261)

Copy link
Contributor

@milo-gsi milo-gsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ErrorDataSetRendererStylingSample works for me now.

@codecov
Copy link

codecov bot commented Sep 22, 2020

Codecov Report

Merging #262 into master will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #262      +/-   ##
============================================
+ Coverage     47.54%   47.55%   +0.01%     
- Complexity     5570     5574       +4     
============================================
  Files           341      341              
  Lines         34843    34843              
  Branches       5700     5701       +1     
============================================
+ Hits          16565    16571       +6     
+ Misses        17232    17230       -2     
+ Partials       1046     1042       -4     
Impacted Files Coverage Δ Complexity Δ
.../main/java/de/gsi/chart/axes/spi/AbstractAxis.java 58.41% <0.00%> (-0.17%) 129.00 <0.00> (ø)
...art/src/main/java/de/gsi/chart/plugins/Zoomer.java 23.63% <0.00%> (+0.08%) 21.00 <0.00> (ø)
...hart/plugins/measurements/DataSetMeasurements.java 75.77% <0.00%> (+0.34%) 153.00% <0.00%> (+2.00%)
...main/java/de/gsi/chart/ui/HiddenSidesPaneSkin.java 43.54% <0.00%> (+0.47%) 29.00% <0.00%> (+1.00%)
...ava/de/gsi/chart/utils/SimplePerformanceMeter.java 88.70% <0.00%> (+1.61%) 31.00% <0.00%> (ø%)
...in/java/de/gsi/dataset/event/EventRateLimiter.java 98.14% <0.00%> (+1.85%) 14.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f170d5...6f38ed7. Read the comment docs.

@RalphSteinhagen RalphSteinhagen merged commit ec32ed0 into master Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants