Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMW client reimplementation #312

Merged
merged 5 commits into from
Nov 13, 2020
Merged

CMW client reimplementation #312

merged 5 commits into from
Nov 13, 2020

Conversation

wirew0rm
Copy link
Member

Adds wire format level documentation and a first version (subscription client only) of the cmw protocol.

@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #312 (690203e) into master (d634fb8) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #312      +/-   ##
============================================
+ Coverage     50.89%   50.91%   +0.02%     
- Complexity     7080     7087       +7     
============================================
  Files           382      382              
  Lines         40501    40501              
  Branches       6523     6523              
============================================
+ Hits          20614    20623       +9     
+ Misses        18427    18422       -5     
+ Partials       1460     1456       -4     
Impacted Files Coverage Δ Complexity Δ
.../main/java/de/gsi/chart/axes/spi/AbstractAxis.java 76.11% <0.00%> (+0.29%) 180.00% <0.00%> (+1.00%)
...hart/plugins/measurements/DataSetMeasurements.java 75.77% <0.00%> (+0.34%) 153.00% <0.00%> (+2.00%)
...main/java/de/gsi/chart/ui/HiddenSidesPaneSkin.java 44.97% <0.00%> (+0.47%) 35.00% <0.00%> (+1.00%)
...java/de/gsi/serializer/spi/CmwLightSerialiser.java 65.52% <0.00%> (+0.51%) 100.00% <0.00%> (+2.00%)
...e/gsi/serializer/spi/WireDataFieldDescription.java 67.88% <0.00%> (+0.91%) 52.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d634fb8...690203e. Read the comment docs.

Copy link
Member

@RalphSteinhagen RalphSteinhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 as discussed. Very good concept and ready for integration

Copy link
Member

@RalphSteinhagen RalphSteinhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-rebase to master

@RalphSteinhagen RalphSteinhagen merged commit 41a1110 into master Nov 13, 2020
@RalphSteinhagen RalphSteinhagen deleted the akrimmCmwClient branch November 13, 2020 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants