Fix MultiArray and DoubleGrid data set to use row major storage as documented #329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MultiArray container was documented to use row-major storage to be compatible with c++ and other existing code, but implemented as column major.
This PR fixes this discrepancy by using row-major.
Also DoubleGridData set had to be adapted, because the expectation here that colums correspond to the x-axis and rows to the y-axis, so the data has to be transposed here.
If they do not use the internal MultiArray type, nothing should change for end users, there are not modifications to the samples.