Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle add visibility state and toggling of datasets #482

Closed
wants to merge 9 commits into from

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented Jan 15, 2022

A duplicate of #481 with additional commits that automatically address
incorrect style, created by Restyled.

⚠️ Even though this PR is not a Fork, it contains outside contributions.
Please review accordingly.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/GSI-CS-CO/chart-fx.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

@restyled-io restyled-io bot temporarily deployed to coverage February 9, 2022 17:21 Inactive
@restyled-io restyled-io bot temporarily deployed to coverage February 9, 2022 17:21 Inactive
@restyled-io restyled-io bot temporarily deployed to coverage February 9, 2022 17:21 Inactive
@restyled-io restyled-io bot temporarily deployed to deploy February 9, 2022 17:25 Inactive
@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #482 (9254bfd) into master (89a5ad3) will decrease coverage by 0.19%.
The diff coverage is 30.90%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #482      +/-   ##
============================================
- Coverage     53.63%   53.43%   -0.20%     
+ Complexity     7477     7473       -4     
============================================
  Files           389      389              
  Lines         40952    40989      +37     
  Branches       6604     6615      +11     
============================================
- Hits          21963    21903      -60     
- Misses        17404    17501      +97     
  Partials       1585     1585              
Impacted Files Coverage Δ
...rc/main/java/de/gsi/chart/plugins/EditDataSet.java 23.21% <0.00%> (-0.19%) ⬇️
...gsi/chart/renderer/spi/ContourDataSetRenderer.java 76.04% <0.00%> (ø)
...gsi/chart/renderer/spi/LabelledMarkerRenderer.java 83.87% <0.00%> (-1.10%) ⬇️
.../gsi/chart/renderer/spi/MountainRangeRenderer.java 0.00% <0.00%> (ø)
...e/gsi/chart/renderer/spi/ReducingLineRenderer.java 0.00% <0.00%> (ø)
...rt/renderer/spi/financial/CandleStickRenderer.java 88.60% <0.00%> (-0.64%) ⬇️
.../chart/renderer/spi/financial/HighLowRenderer.java 85.33% <0.00%> (-0.67%) ⬇️
...-dataset/src/main/java/de/gsi/dataset/DataSet.java 100.00% <ø> (ø)
...ain/java/de/gsi/dataset/spi/TransposedDataSet.java 84.42% <0.00%> (-1.41%) ⬇️
.../de/gsi/dataset/testdata/spi/ErrorTestDataSet.java 74.69% <0.00%> (-1.85%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89a5ad3...9254bfd. Read the comment docs.

@restyled-io restyled-io bot temporarily deployed to coverage February 9, 2022 18:22 Inactive
@restyled-io restyled-io bot temporarily deployed to coverage February 9, 2022 18:22 Inactive
@restyled-io restyled-io bot temporarily deployed to coverage February 9, 2022 18:22 Inactive
@restyled-io restyled-io bot temporarily deployed to coverage February 9, 2022 18:22 Inactive
@restyled-io restyled-io bot temporarily deployed to deploy February 9, 2022 18:26 Inactive
@restyled-io restyled-io bot temporarily deployed to deploy February 9, 2022 18:26 Inactive
@restyled-io restyled-io bot closed this Feb 10, 2022
@restyled-io restyled-io bot deleted the restyled/visibility-state branch February 10, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants