Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: MSYS Compatible npm scripts (since using devDependencies) #104

Merged
merged 4 commits into from
Jan 13, 2022
Merged

fix: MSYS Compatible npm scripts (since using devDependencies) #104

merged 4 commits into from
Jan 13, 2022

Conversation

fzn0x
Copy link
Contributor

@fzn0x fzn0x commented Jan 12, 2022

Fix :

> faker@5.5.3 jsdoc
> ./node_modules/gulp jsdoc

'.' is not recognized as an internal or external command,
operable program or batch file.

Shinigami92
Shinigami92 requested changes Jan 12, 2022
View reviewed changes
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you revert examples/browser/js/faker.js and examples/browser/js/faker.min.js?
It's not possible to review them and they get auto-generated by us anyways

@Shinigami92 Shinigami92 added the c: chore PR that doesn't affect the runtime behavior label Jan 12, 2022
@fzn0x
Copy link
Contributor Author

fzn0x commented Jan 12, 2022

Could you revert examples/browser/js/faker.js and examples/browser/js/faker.min.js? It's not possible to review them and they get auto-generated by us anyways

Reverted to 3f7d698

@netlify
Copy link

netlify bot commented Jan 13, 2022 •
edited
Loading

✔️ Deploy Preview for vigilant-wescoff-04e480 ready!

🔨 Explore the source changes: fc5b922

🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-wescoff-04e480/deploys/61df9b85e78faa0008861347

😎 Browse the preview: https://deploy-preview-104--vigilant-wescoff-04e480.netlify.app

@prisis prisis merged commit 7d6f2d8 into faker-js:main Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prisis prisis prisis approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees
No one assigned
Labels
c: chore PR that doesn't affect the runtime behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fzn0x @prisis @Shinigami92