Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add files field in package.json #173

Merged
merged 4 commits into from
Jan 16, 2022

Conversation

MohdImran001
Copy link
Contributor

Fixes #156

@Shinigami92 please review

@netlify
Copy link

netlify bot commented Jan 16, 2022

✔️ Deploy Preview for vigilant-wescoff-04e480 ready!

🔨 Explore the source changes: d745076

🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-wescoff-04e480/deploys/61e46990c65f2e0007ee814a

😎 Browse the preview: https://deploy-preview-173--vigilant-wescoff-04e480.netlify.app

@Shinigami92 Shinigami92 added the c: chore PR that doesn't affect the runtime behavior label Jan 16, 2022
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete .npmignore

package.json Outdated Show resolved Hide resolved
@Shinigami92
Copy link
Member

There is also a dist folder 🤔
@damienwebdev is that also needed? Or how does this folder work?

@Shinigami92 Shinigami92 added this to the v6.0.0 milestone Jan 16, 2022
package.json Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 linked an issue Jan 16, 2022 that may be closed by this pull request
@Shinigami92 Shinigami92 added p: 3-urgent Fix and release ASAP and removed c: chore PR that doesn't affect the runtime behavior labels Jan 16, 2022
@Shinigami92 Shinigami92 requested review from prisis and a team January 16, 2022 18:53
@Shinigami92 Shinigami92 merged commit db4c018 into faker-js:main Jan 16, 2022
Shinigami92 added a commit to MohdImran001/faker that referenced this pull request Jan 18, 2022
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: 3-urgent Fix and release ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript error due to missing "types" field build: add src to .npmignore
4 participants