-
-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(git): commitDate explicitly set default for refDate #1750
Conversation
I'm not sure if this should be labeled as |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1750 +/- ##
=======================================
Coverage ? 99.64%
=======================================
Files ? 2340
Lines ? 242612
Branches ? 1103
=======================================
Hits ? 241760
Misses ? 831
Partials ? 21 |
There seems to be a merge conflict. Could you please fix it? |
…ate-default-ref-date
0cf26c0
The default value of the
refDate
option infaker.git.commitDate()
is documented asnow
(new Date()
).This only happens due to the underlying implementation in
faker.date.recent()
.If the default value in
recent()
should change in the future, this change ensures thatcommitDate()
still works the same.