-
-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add node version matrix #179
Conversation
✔️ Deploy Preview for vigilant-wescoff-04e480 ready! 🔨 Explore the source changes: f929c7c 🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-wescoff-04e480/deploys/61e7378a80a6a2000892579f 😎 Browse the preview: https://deploy-preview-179--vigilant-wescoff-04e480.netlify.app |
@MohdImran001 do you need help with it? |
Sorry I was a bit busy , I will complete this today. |
@MohdImran001 Please remove the dependency |
Nice, now node 14 and 12 is working 👍 |
It's actually this test: Lines 283 to 299 in d72482b
|
6365f20
to
f929c7c
Compare
I am unable to reproduce the test error on both my win11 and win10 computers. |
I hacked around it by conditionally disable the test on |
Co-authored-by: Shinigami92 <chrissi92@hotmail.de>
Fixes #159
@prisis please review