-
-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update eslint #2771
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2771 +/- ##
==========================================
- Coverage 99.93% 99.93% -0.01%
==========================================
Files 2960 2960
Lines 211726 211726
Branches 601 947 +346
==========================================
- Hits 211592 211578 -14
- Misses 130 148 +18
+ Partials 4 0 -4 |
1f0a821
to
9f68dd3
Compare
Is the failure expected or a bug? |
9f68dd3
to
3b34ea3
Compare
Need to evaluate on a big screen. Will hopefully do this around evening. |
a50eb4c
to
e6342e1
Compare
Seems I see no big problem with code like
Error:
|
It is the default since v6.0, but the config options might have changed:
Maybe we should just allow string number again: '@typescript-eslint/restrict-plus-operands': [
'error',
{
allowAny: false,
allowBoolean: false,
allowNullish: false,
allowNumberAndString: true,
allowRegExp: false,
},
], Does anybody know how the config merging works? |
e6342e1
to
306d4b4
Compare
This depends on how it is implemented. For example, this is the reason why we do option destruction like we do, cause otherwise we would fall into undefined => falsy fallbacks by accident. |
b3958d4
to
e8eee1c
Compare
e8eee1c
to
cac6b30
Compare
seems '@typescript-eslint/restrict-plus-operands': [
'error',
{
allowNumberAndString: true
},
], is sufficient to override that case. The other remaining error is
I dont understand well enough what |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
Thanks for having a look at this.
To overwrite the config, yes, but it does also overwrite the stricter config from here: I restored the strict config except for that flag. Can be checked with the
The cast is now redundant. I'm not sure why exactly, but it is safe to remove. |
This PR contains the following updates:
48.2.0
->48.2.1
7.0.2
->7.2.0
7.2.0
->7.4.0
7.2.0
->7.4.0
48.2.1
->48.2.2
0.3.26
->0.4.1
Release Notes
typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)
v7.4.0
Compare Source
🚀 Features
eslint-plugin: [consistent-type-imports] ignore files with decorators, experimentalDecorators, and emitDecoratorMetadata
eslint-plugin: [no-unnecessary-type-arguments] handle tagged templates
eslint-plugin: deprecate no-throw-literal and add a renamed only-throw-error
🩹 Fixes
eslint-plugin: [prefer-optional-chain] address multipart nullish checks false positive
eslint-plugin: [prefer-optional-chain] properly disambiguate between
boolean
andfalse
eslint-plugin: [no-unnecessary-type-assertion] avoid remove const casting on template literals with expressions inside
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v7.3.1
Compare Source
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v7.3.0
Compare Source
🚀 Features
eslint-plugin: [restrict-template-expressions] add
allowArray
optioneslint-plugin: add meta.docs.recommended setting for strict config options
eslint-plugin: add rule
use-unknown-in-catch-callback-variables
eslint-plugin: [prefer-reduce-type-parameter] supports tuple, union, intersection
🩹 Fixes
correct
engines.node
constraints inpackage.json
eslint-plugin: [unbound-method] check method definition in object literal using longhand form
eslint-plugin: [consistent-type-imports] handle imports without specifiers
eslint-plugin: [no-redundant-type-constituents] incorrectly marks & string as redundant
eslint-plugin: [no-unnecessary-qualifier] handle merge namespace with enum
eslint-plugin: [no-unused-expressions] false negatives when using assertions
eslint-plugin: [ban-ts-comment] more accurate handling of multiline comments
eslint-plugin: [explicit-function-return-type, explicit-module-boundary-types] improved checking for allowHigherOrderFunctions option
eslint-plugin: [class-literal-property-style] ignore property assigned in constructor
eslint-plugin: [no-unnecessary-type-assertion] fix false negative for const variable declarations
❤️ Thank You
You can read about our versioning strategy and releases on our website.
typescript-eslint/typescript-eslint (@typescript-eslint/parser)
v7.4.0
Compare Source
v7.3.1
Compare Source
This was a version bump only for parser to align it with other projects, there were no code changes.
You can read about our versioning strategy and releases on our website.
v7.3.0
Compare Source
🩹 Fixes
engines.node
constraints inpackage.json
❤️ Thank You
You can read about our versioning strategy and releases on our website.
gajus/eslint-plugin-jsdoc (eslint-plugin-jsdoc)
v48.2.2
Compare Source
Bug Fixes
import
tag; fixes #1218 (9e9fed5)veritem/eslint-plugin-vitest (eslint-plugin-vitest)
v0.4.1
Compare Source
Full Changelog: vitest-dev/eslint-plugin-vitest@v0.4.1...v0.4.1
Changes
max-expect
rule in favor ofmax-expects
v0.4.0
Compare Source
Bug Fixes
Full Changelog: vitest-dev/eslint-plugin-vitest@v0.4.0...v0.4.0
Configuration
📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Mend Renovate. View repository job log here.