Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): remove dependency @types/markdown-it #2800

Merged
merged 2 commits into from
Apr 8, 2024
Merged

chore(deps): remove dependency @types/markdown-it #2800

merged 2 commits into from
Apr 8, 2024

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: dependencies Pull requests that adds/updates a dependency labels Apr 8, 2024
@Shinigami92 Shinigami92 added this to the vAnytime milestone Apr 8, 2024
@Shinigami92 Shinigami92 self-assigned this Apr 8, 2024
@Shinigami92 Shinigami92 requested a review from a team as a code owner April 8, 2024 09:25
@netlify Netlify
Copy link

netlify bot commented Apr 8, 2024 •
edited
Loading

✅ Deploy Preview for fakerjs canceled.

Name Link
🔨 Latest commit e143c50
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/6613c912503a7e000884e35a

@Shinigami92 Shinigami92 changed the title chore(deps) remove dependency @types/markdown-it chore(deps): remove dependency @types/markdown-it Apr 8, 2024
@ST-DDT ST-DDT requested review from a team April 8, 2024 09:28
@codecov Codecov
Copy link

codecov bot commented Apr 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (88d7675) to head (e143c50).

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2800   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files        2972     2972           
  Lines      212564   212564           
  Branches      947      951    +4     
=======================================
+ Hits       212464   212472    +8     
+ Misses        100       92    -8

see 2 files with indirect coverage changes

@Shinigami92 Shinigami92 merged commit 423b39e into next Apr 8, 2024
20 checks passed
@Shinigami92 Shinigami92 deleted the deps-remove-types-markdown-it branch April 8, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: dependencies Pull requests that adds/updates a dependency p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging this pull request may close these issues.
3 participants
@Shinigami92 @ST-DDT @xDivisionByZerox