Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): implement more colors to pt_PT locale #3021

Conversation

jeanpierrecarvalho
Copy link
Contributor

Issue #3021: Addition of More Colors to pt_PT Locale

Changes Made:

  • Added additional color names to the Portuguese (pt_PT) locale in the data file.

Details of Changes:

  • Expanded the list of color names to include more variations and shades.
  • Ensured consistency in the use of special characters and accents according to the pt_PT locale.
  • Verified and corrected the color names for proper Portuguese translations.

Additional Details:

The additions were made to enhance the localization and ensure a comprehensive representation of color names in Portuguese.

@jeanpierrecarvalho jeanpierrecarvalho requested a review from a team as a code owner July 16, 2024 00:12
Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for fakerjs canceled.

Name Link
🔨 Latest commit 7651957
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66be2c4db44a320008ef4a32

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (8c55493) to head (7651957).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3021      +/-   ##
==========================================
- Coverage   99.97%   99.97%   -0.01%     
==========================================
  Files        2772     2772              
  Lines      226182   226221      +39     
  Branches      943      942       -1     
==========================================
+ Hits       226125   226154      +29     
- Misses         57       67      +10     
Files Coverage Δ
src/locales/pt_PT/color/human.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: color Something is referring to the color module labels Jul 16, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Jul 16, 2024
@ST-DDT ST-DDT requested review from a team July 16, 2024 11:32
@ST-DDT ST-DDT changed the title feat: implement more colors to pt_PT locale feat(locale): implement more colors to pt_PT locale Jul 16, 2024
@xDivisionByZerox
Copy link
Member

This is scheduled for vAnytime and has 4 approvals. Should this be merged to land in v9? I don't see any reason not to do so.

@xDivisionByZerox xDivisionByZerox merged commit a210619 into faker-js:next Aug 15, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: color Something is referring to the color module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants