Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): implement state info on sk locale #3054

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

boubkerbribri
Copy link
Contributor

@boubkerbribri boubkerbribri commented Aug 13, 2024

Issue Number

#3052

Changes Made

@boubkerbribri boubkerbribri requested a review from a team as a code owner August 13, 2024 08:38
Copy link

netlify bot commented Aug 13, 2024

Deploy Preview for fakerjs canceled.

Name Link
🔨 Latest commit 86f41f3
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66be2b5044c2620008ffcd8a

@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone Aug 13, 2024
@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: location Something is referring to the location module labels Aug 13, 2024
@xDivisionByZerox
Copy link
Member

@boubkerbribri you need to adjust the test in test/all-functional.spec.ts. You need to remove sk from the "broken locale" dictionary:

state: ['az', 'nb_NO', 'ro_MD', 'sk'],

Additionally, you should run the preflight command before committing to verify your changes locally.

@boubkerbribri
Copy link
Contributor Author

@boubkerbribri you need to adjust the test in test/all-functional.spec.ts. You need to remove sk from the "broken locale" dictionary:

state: ['az', 'nb_NO', 'ro_MD', 'sk'],

Additionally, you should run the preflight command before committing to verify your changes locally.

Should be all good now, thanks

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (466c8ba) to head (86f41f3).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3054   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files        2772     2772           
  Lines      226173   226182    +9     
  Branches      945      939    -6     
=======================================
+ Hits       226102   226111    +9     
  Misses         71       71           
Files Coverage Δ
src/locales/sk/location/state.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT requested review from matthewmayer and a team August 13, 2024 09:37
@ST-DDT ST-DDT linked an issue Aug 13, 2024 that may be closed by this pull request
10 tasks
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@xDivisionByZerox xDivisionByZerox merged commit 8c55493 into faker-js:next Aug 15, 2024
21 checks passed
@boubkerbribri boubkerbribri deleted the feat/sk-locale branch August 19, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

faker.location.state() not working for sk
5 participants