Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(location): en_CA postcodes by state #3057

Merged
merged 4 commits into from
Aug 19, 2024
Merged

feat(location): en_CA postcodes by state #3057

merged 4 commits into from
Aug 19, 2024

Conversation

matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer commented Aug 15, 2024 •
edited
Loading

Implements postcode_by_state for en_CA

@netlify Netlify
Copy link

netlify bot commented Aug 15, 2024 •
edited
Loading

✅ Deploy Preview for fakerjs canceled.

Name Link
🔨 Latest commit 2493de0
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66c3a71ed86c700008821f65

@codecov Codecov
Copy link

codecov bot commented Aug 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (cc7715b) to head (2493de0).
Report is 1 commits behind head on next.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #3057      +/-   ##
==========================================
- Coverage   99.97%   99.96%   -0.01%     
==========================================
  Files        2775     2776       +1     
  Lines      226242   226260      +18     
  Branches      944      942       -2     
==========================================
+ Hits       226181   226188       +7     
- Misses         61       72      +11
Files Coverage Δ
src/locales/en_CA/location/index.ts 100.00% <100.00%> (ø)
src/locales/en_CA/location/postcode_by_state.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@matthewmayer matthewmayer marked this pull request as ready for review August 15, 2024 22:50
@matthewmayer matthewmayer requested a review from a team as a code owner August 15, 2024 22:50
@Shinigami92
Copy link
Member

FFR: This issue was originally reported by @Zombiebrainz on Discord

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: location Something is referring to the location module labels Aug 17, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Aug 17, 2024
@matthewmayer @ST-DDT
Update postcode_by_state.ts
f05653c 
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
ST-DDT
ST-DDT previously approved these changes Aug 17, 2024
View reviewed changes
src/locales/en_CA/location/postcode_by_state.ts Outdated Show resolved Hide resolved
@matthewmayer @ST-DDT
Update postcode_by_state.ts
3fc43cc 
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
@ST-DDT ST-DDT requested review from a team August 18, 2024 07:57
@matthewmayer matthewmayer changed the title feat(location): ca postcodes by state feat(location): en_CA postcodes by state Aug 18, 2024
@ST-DDT ST-DDT enabled auto-merge (squash) August 19, 2024 20:12
@ST-DDT ST-DDT merged commit b62c1b7 into faker-js:next Aug 19, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees

@matthewmayer matthewmayer

Labels
c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewmayer @Shinigami92 @ST-DDT