Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(location): adjust zipCode nullish checks #3080

Merged
merged 4 commits into from
Sep 15, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Sep 1, 2024

This PR changes the implementation of zipCode to replace the falsy checks with explicit nullish checks.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: location Something is referring to the location module labels Sep 1, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Sep 1, 2024
@ST-DDT ST-DDT requested review from a team September 1, 2024 18:04
@ST-DDT ST-DDT self-assigned this Sep 1, 2024
Copy link

netlify bot commented Sep 1, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 1a60137
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66e600a64802720008bd071a
😎 Deploy Preview https://deploy-preview-3080.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (79d8f2b) to head (1a60137).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3080      +/-   ##
==========================================
- Coverage   99.97%   99.96%   -0.01%     
==========================================
  Files        2776     2776              
  Lines      226260   226262       +2     
  Branches      591      592       +1     
==========================================
- Hits       226206   226193      -13     
- Misses         54       69      +15     
Files with missing lines Coverage Δ
src/modules/location/index.ts 99.05% <100.00%> (-0.95%) ⬇️

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT requested a review from a team September 1, 2024 19:00
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not complain about this change, but has this been a problem before? Is there a GH issue I didn't notice?

@ST-DDT
Copy link
Member Author

ST-DDT commented Sep 15, 2024

I do not complain about this change, but has this been a problem before? Is there a GH issue I didn't notice?

No, its only for consistency with our other code.

@xDivisionByZerox xDivisionByZerox merged commit 15fd536 into next Sep 15, 2024
23 checks passed
@xDivisionByZerox xDivisionByZerox deleted the refactor/location/zipCode branch September 15, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: location Something is referring to the location module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants