Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix avatarLegacy deprecation version typo #3124

Merged
merged 2 commits into from
Sep 22, 2024
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Sep 20, 2024

Fixes the typo introduced in #3109

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent m: image Something is referring to the image module labels Sep 20, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Sep 20, 2024
@ST-DDT ST-DDT requested review from a team September 20, 2024 19:59
@ST-DDT ST-DDT self-assigned this Sep 20, 2024
Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit f2dc9bb
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66eeff597df9d400088d69e9
😎 Deploy Preview https://deploy-preview-3124.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ST-DDT ST-DDT enabled auto-merge (squash) September 20, 2024 20:00
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (c15b488) to head (f2dc9bb).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3124   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files        2776     2776           
  Lines      226341   226341           
  Branches      574      577    +3     
=======================================
+ Hits       226253   226271   +18     
+ Misses         88       70   -18     
Files with missing lines Coverage Δ
src/modules/image/index.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's maybe wait before we decide whether we release a 9.1 or 9.0.2 next

@ST-DDT
Copy link
Member Author

ST-DDT commented Sep 21, 2024

Let's maybe wait before we decide whether we release a 9.1 or 9.0.2 next

I would like to do a 9.0.2 asap to verify release provenance is working properly after this is merged.

@ST-DDT ST-DDT requested a review from a team September 21, 2024 17:16
@ST-DDT ST-DDT merged commit 6e72712 into next Sep 22, 2024
23 checks passed
@ST-DDT ST-DDT deleted the chore/image/since-typo branch September 22, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior m: image Something is referring to the image module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants